Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add D457 #2557

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Add D457 #2557

merged 1 commit into from
Jan 26, 2023

Conversation

hsuys
Copy link
Contributor

@hsuys hsuys commented Nov 22, 2022

Enabling D457

@Nir-Az
Copy link
Collaborator

Nir-Az commented Jan 25, 2023

Hi @hsuys ,
We merged this PR who should enable the D457 with no librealsense change.
Can you help by verifying your PR (rebased) works with the default `rs_launch.py' so we can merge it?

@hsuys
Copy link
Contributor Author

hsuys commented Jan 26, 2023 •
edited
Loading

Thank you very much for #2601.
I've verified my PR now works with default rs_launch.py.

Nir-Az
Nir-Az approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great thanks 😀

@Nir-Az Nir-Az merged commit 6dcdc1f into IntelRealSense:ros2-development Jan 26, 2023
@MartyG-RealSense MartyG-RealSense mentioned this pull request Mar 24, 2023
Closed
@hsuys hsuys deleted the enable_D457 branch March 28, 2023 16:12
@MartyG-RealSense MartyG-RealSense mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsuys @Nir-Az