-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing zr300 launch file arguments #259
Added missing zr300 launch file arguments #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
can this be merged please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @ipa-bnm, thank you for your helping!
There is more work to be done regarding this change. Currently the new parameters appears only in the Launch file and not referenced/published from the source code. As a result, no data is published under the new messages. for instance, there is no data published under /camera/fisheye/camera_info .
Please take a look how we publish the other ROS messages: depth, rgb, ir, depth_optical_frame_id and etc.
Hello @icarpis. I think there is a little misunderstanding. This PR is just adding missing launch file params and topic remaps for the zr300 camera. The driver is already reading this params from the parameter server. Take a look here: https://github.com/intel-ros/realsense/blob/indigo-devel/realsense_camera/src/zr300_nodelet.cpp#L98-L112 The zr300 driver is also already publishing imu and fisheye data to the default topic names. To be able to change the topic names I've introduced these two remappings. Also, if we would like the use the For cameras without imu and/or fisheye (r200 for example) this PR should be fine as well, because other realsense camera will just ignore this remaps and params. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ipa-bnm, thank you for the clarification.
I ran this PR on ZR300, R200 and SR300 to make sure nothing was broken.
Added missing zr300 launch file arguments
Fixes Issue: #258
Changes proposed in this pull request: