Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing zr300 launch file arguments #259

Merged
merged 3 commits into from
Sep 12, 2017

Conversation

benmaidel
Copy link

Fixes Issue: #258

Changes proposed in this pull request:

  • added missing zr300 arguments to launch file

@benmaidel benmaidel changed the title set ir_optical imu and fisheye frame names inside nodelet_rgbd.launch… added missing zr300 launch file arguments Jul 27, 2017
@benmaidel benmaidel changed the title added missing zr300 launch file arguments Added missing zr300 launch file arguments Jul 27, 2017
Copy link

@fmessmer fmessmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fmessmer
Copy link

fmessmer commented Sep 6, 2017

can this be merged please?

Copy link
Contributor

@icarpis icarpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ipa-bnm, thank you for your helping!
There is more work to be done regarding this change. Currently the new parameters appears only in the Launch file and not referenced/published from the source code. As a result, no data is published under the new messages. for instance, there is no data published under /camera/fisheye/camera_info .
Please take a look how we publish the other ROS messages: depth, rgb, ir, depth_optical_frame_id and etc.

@benmaidel
Copy link
Author

Hello @icarpis. I think there is a little misunderstanding. This PR is just adding missing launch file params and topic remaps for the zr300 camera. The driver is already reading this params from the parameter server. Take a look here: https://github.com/intel-ros/realsense/blob/indigo-devel/realsense_camera/src/zr300_nodelet.cpp#L98-L112 The zr300 driver is also already publishing imu and fisheye data to the default topic names. To be able to change the topic names I've introduced these two remappings. Also, if we would like the use the nodelet_rgbd.launch.xml together with the zr300 camera we need to pass the frame_id params. Otherwise we will not be able to set the frame_ids for fisheye, fisheye_optical, ir_optical, ir2_optical, imu and imu_optical. See this Issue #258

For cameras without imu and/or fisheye (r200 for example) this PR should be fine as well, because other realsense camera will just ignore this remaps and params.

Copy link
Contributor

@icarpis icarpis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipa-bnm, thank you for the clarification.
I ran this PR on ZR300, R200 and SR300 to make sure nothing was broken.

@icarpis icarpis merged commit 46e63f5 into IntelRealSense:indigo-devel Sep 12, 2017
rsinnet pushed a commit to MisoRobotics/realsense that referenced this pull request Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants