Fix ros2 parameter descriptions and range values #2600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge yet. |
You can convert a PR into a draft (see |
Nir-Az
reviewed
Jan 30, 2023
| option_value = static_cast<T>(sensor.get_option(option)); | ||
| op_range = sensor.get_option_range(option); | ||
| float current_val = sensor.get_option(option); | ||
| if(std::is_same<T, double>::value && current_val > 0) |
Nir-Az
reviewed
Jan 30, 2023
| } | ||
| else | ||
| { | ||
| rcl_interfaces::msg::FloatingPointRange range; | ||
| range.from_value = double(op_range.min); | ||
| range.to_value = double(op_range.max); | ||
| range.from_value = static_cast<double>(op_range.min); |
There was a problem hiding this comment.
Maybe needs conversion too?
SamerKhshiboun
changed the title
Nir-Az
reviewed
Jan 31, 2023
| float range = option_range.max - option_range.min; | ||
| int steps = range / option_range.step; | ||
| double step = static_cast<double>(range) / steps; | ||
| double rounded_div = std::round((val - option_range.min) / step); |
There was a problem hiding this comment.
Please protect div_by_zero. for both devision operations
There was a problem hiding this comment.
@SamerKhshiboun we forgot about it before merging please add protection
I wonder why cppcheck didn't shout on it..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by [DSO-18759]