Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Apache License Header and Intel Copyrights #2608

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Fix Apache License Header and Intel Copyrights #2608

merged 1 commit into from
Feb 1, 2023

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented Jan 29, 2023 •
edited
Loading

  • Tracked on [LRS-653]
  • change copyrights and license to meet Apache 2.0 standard (see end of page of: https://www.apache.org/licenses/LICENSE-2.0)
  • applied (automatically with copyright command) all changes above, so many files headers have been changed.
  • added (auto-generated) CONTRIBUTING.md to the root directory to meet APACHE license
  • fixed pr_check to take license and copyright from LICENSE file
  • updated LICENSE file
  • updated main.yaml workflow to do first the pr_check before install CMake or any other further steps

@SamerKhshiboun SamerKhshiboun changed the title apply ament_cppcheck and ament_copyright Fix Apache License Header and Intel Copyrights Jan 31, 2023
@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review January 31, 2023 16:23
@SamerKhshiboun SamerKhshiboun requested a review from Nir-Az January 31, 2023 16:23
Nir-Az
Nir-Az reviewed Jan 31, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Nir-Az
Copy link
Collaborator

Nir-Az commented Jan 31, 2023

Great PR.

Lets just speak about the contributors file

Nir-Az
Nir-Az reviewed Feb 1, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
Nir-Az
Nir-Az approved these changes Feb 1, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@Nir-Az Nir-Az merged commit 40721bd into IntelRealSense:ros2-development Feb 1, 2023
@SamerKhshiboun SamerKhshiboun deleted the add_cppcheck branch February 7, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @Nir-Az