Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cppcheck to GHA #2610

Merged
merged 1 commit into from
Feb 2, 2023
Merged

add cppcheck to GHA #2610

merged 1 commit into from
Feb 2, 2023
+79 −9

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented Jan 30, 2023 •
edited
Loading

Tracked on [LRS-658]

  • used static_anaylsis.yaml from librealsense repo as reference
  • added new GitHub Action workflow: static_analysis.yaml
  • fixed cppcheck warnings of cpp and h files to be on 0 expected errors

@SamerKhshiboun SamerKhshiboun marked this pull request as draft January 30, 2023 02:33
@SamerKhshiboun SamerKhshiboun force-pushed the add_cppcheck_to_gha branch 2 times, most recently from e39d77f to 4404564 Compare February 1, 2023 21:35
@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review February 1, 2023 22:52
@SamerKhshiboun SamerKhshiboun requested a review from Nir-Az February 1, 2023 22:52
Nir-Az
Nir-Az approved these changes Feb 2, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 839d837 into IntelRealSense:ros2-development Feb 2, 2023
@SamerKhshiboun SamerKhshiboun deleted the add_cppcheck_to_gha branch February 7, 2023 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @Nir-Az