Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use playback device for rosbags #2669

Merged
merged 1 commit into from
Apr 3, 2023
Merged

use playback device for rosbags #2669

merged 1 commit into from
Apr 3, 2023

Conversation

SamerKhshiboun
Copy link
Contributor

@SamerKhshiboun SamerKhshiboun commented Mar 26, 2023 •
edited
Loading

when running a playback device, from a rosbag file, use the playback API, instead of pipe->start() which caused losing frames

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review April 3, 2023 09:10
@SamerKhshiboun SamerKhshiboun requested a review from Nir-Az April 3, 2023 09:12
Nir-Az
Nir-Az approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 00d23c4 into IntelRealSense:ros2-development Apr 3, 2023
@SamerKhshiboun SamerKhshiboun deleted the rosbags-patch-1 branch May 9, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @Nir-Az