Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rs_launch configurations #2822

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

Arun-Prasad-V
Copy link
Contributor

@Arun-Prasad-V Arun-Prasad-V commented Jul 25, 2023

Issue:

  • In rs_multi_camera_launch.py, '1' and '2' are appended as suffix of actual param names listed in rs_launch.py. For example: enable_infra param name from rs_launch.py becomes enable_infra1 and enable_infra2. But, there are already params with those names in rs_launch.py. This leads to misconfiguration of params.

Root cause:

  • Misconfiguration happens because while running rs_multi_camera_launch.py both actual and appended param names are getting registered
  • No need to register actual param names from rs_launch.py
  • Should register only appended param names

Fix:

  • Updating rs_launch.py to support getting only required param names dynamically and register them

Copy link
Contributor

@SamerKhshiboun SamerKhshiboun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix Arun !

@Nir-Az Nir-Az merged commit 920aa3a into IntelRealSense:ros2-development Jul 25, 2023
@Arun-Prasad-V Arun-Prasad-V deleted the launch_config branch August 10, 2023 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants