Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rs_multi_camera_launch.py
, '1' and '2' are appended as suffix of actual param names listed inrs_launch.py
. For example:enable_infra
param name fromrs_launch.py
becomesenable_infra1
andenable_infra2
. But, there are already params with those names inrs_launch.py
. This leads to misconfiguration of params.Root cause:
rs_multi_camera_launch.py
both actual and appended param names are getting registeredrs_launch.py
Fix:
rs_launch.py
to support getting only required param names dynamically and register them