Added live camera tests #2865
Added live camera tests #2865
Conversation
| return True | ||
| if "Y16" == format: | ||
| return True | ||
| if "Y10BPACK" == format: |
There was a problem hiding this comment.
do we skip this or not ?
There was a problem hiding this comment.
We are skipping for now, as these formats are failing on one device_type or the other
| self.set_bool_param('enable_gyro', True) | ||
| themes[ACCEL_TOPIC]['expected_data_chunks'] = 0 | ||
| #uncomment once RSDEV-550 is closed | ||
| #themes[IMU_TOPIC]['expected_data_chunks'] = 0 |
There was a problem hiding this comment.
Hi @PrasRsRos,
Please pull latest changes from ros2-development, since Arun PR has been merged.
IMU topic should not be available if gyro/accel are turned off.
Please fix tests accordingly.
| @@ -0,0 +1,268 @@ | |||
| # Copyright 2023 Intel Corporation. All Rights Reserved. | |||
There was a problem hiding this comment.
in a second thought, I think this file should not be exists.
The best option is to open a sperate ticket in Jira for this, and to handle these formats/streams issues later.
on my machines, I could not make these configurations fail.
| 'device_type': 'D455', | ||
| 'enable_accel':"True", | ||
| 'enable_gyro':"True", | ||
| 'unite_imu_method':1, |
There was a problem hiding this comment.
'unite_imu_method' param can also be updated dynamically. If needed, please update the tests.
|
@PrasRsRos, can you please resolve the conflicts so I can merge it ? |
…e '/topic' provided by user
SamerKhshiboun
merged commit 8de679b
into
IntelRealSense:ros2-development
…realsense-ros into add-live-camera-tests
No description provided.