Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ros random crash with error hw monitor command for asic temperature failed #2946

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix ros random crash with error hw monitor command for asic temperature failed #2946

merged 1 commit into from
Dec 15, 2023

Conversation

gwen2018
Copy link
Contributor

fix ros random crash with error hw monitor command for asic temperature failed

changes:
add error handling to avoid crash when asic temperature monitor occasionally fails and throws exception

Tracked on: LRS-982

Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit 91c0f35 into IntelRealSense:ros2-development Dec 15, 2023
6 checks passed
@tonynajjar
Copy link
Contributor

tonynajjar commented May 29, 2024

hey @Nir-Az , I'm finding myself needing this in 4.54.1, since this is a tag and not a branch, how do you handle backports in this repo? More generally how can I get this fix in 4.54.1 without upgrading anything else?

@Nir-Az
Copy link
Collaborator

Nir-Az commented May 29, 2024

Hi,
we released 4.55.1 today, should be merged soon.
If you need this fix on previous versions, you can cherry-pick it and build from source..

@tonynajjar
Copy link
Contributor

tonynajjar commented May 29, 2024

@Nir-Az Thanks for answering quickly

you can cherry-pick it and build from source..

I was hoping I'd have to avoid this... but I guess there is no other way when the repo uses tags instead of branches.
I'm just worried that 4.55.1 might be incompatible with the librealsense version I have (2.54.2). There is no "Supported RealSense SDK" for the latest release, can you say whether it's compatible?

@Nir-Az
Copy link
Collaborator

Nir-Az commented May 30, 2024

We are trying to update our release flow in the future.
Could be the new flow can help on such cases.
Stay tuned :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants