Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert installation from source for foxy distro on ubuntu 20 #3066

Conversation

SamerKhshiboun
Copy link
Collaborator

@SamerKhshiboun SamerKhshiboun commented Mar 31, 2024

Tracked on LRS-1060

  • Updated main.yaml for github action to build ros wrapper for foxy on ubuntu 20.04
  • added foxy to the cmake
  • edited package.xml to include test dependencies only if not foxy
  • fixed code compilation errors due to deprecated functions calls
  • Updated readme
  • Fixed rs_launch.py to support foxy (output param should be string)
  • Removed compilation warnings

@SamerKhshiboun SamerKhshiboun changed the title DRAFT DONT REVIEW - Revert installation from source for foxy distro on ubuntu 20 Revert installation from source for foxy distro on ubuntu 20 Mar 31, 2024
@SamerKhshiboun SamerKhshiboun force-pushed the revert_foxy_support branch 17 times, most recently from 6d4b996 to 7580af6 Compare April 3, 2024 19:44
@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review April 3, 2024 21:30
@SamerKhshiboun SamerKhshiboun force-pushed the revert_foxy_support branch 3 times, most recently from fb4da86 to 314948b Compare April 3, 2024 21:48
@SamerKhshiboun SamerKhshiboun force-pushed the revert_foxy_support branch 2 times, most recently from 62ece91 to d80ccf4 Compare April 7, 2024 17:36
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@SamerKhshiboun SamerKhshiboun merged commit 34350e7 into IntelRealSense:ros2-development Apr 8, 2024
6 of 7 checks passed
@SamerKhshiboun SamerKhshiboun deleted the revert_foxy_support branch June 8, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants