Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the aligned depth frame unit conversion issue #367

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

AlanBB277
Copy link
Contributor

Greeting maintainers,

Thanks for maintaining this repo. It really helps my project in a big way.

The thing is, the readings of the aligned depth frames on SR300 are incorrect currently, so I've sent a PR to fix it.

The issue was caused by converting the depth frame unit byte by byte, but the frame is encoded in 16UC1.

Since there is no need to do unit conversion on DS400 series(unit = 0.001), so this issue only appears on SR300 camera(unit = 0.000124987).

This PR has been verified on my side with SR300. If you agree with this modification, please help me to verify it on DS400 series.

If there is any suggestion for this PR, please feel free to advise me.

Thanks again! Hope this helps :)

Alan

@dorodnic
Copy link
Contributor

Hi @AlanBB277
Thank you for the pull-request!
This looks correct to me, but it might take a bit more time to properly test it and publish into the next release.

@oka1125
Copy link
Contributor

oka1125 commented Apr 24, 2018

Hi @AlanBB277
I found the same issue with SR300 camera.
Thank you for the pull-request.

@lz89
Copy link

lz89 commented Jun 11, 2018

I tested with D435 and it seems working fine. It also fix the issue that if the param-depthunits is changed from 1000 to 100, the reconstructed results would be wrong.

@doronhi doronhi merged commit 728ac16 into IntelRealSense:development Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants