fix the aligned depth frame unit conversion issue #367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greeting maintainers,
Thanks for maintaining this repo. It really helps my project in a big way.
The thing is, the readings of the aligned depth frames on SR300 are incorrect currently, so I've sent a PR to fix it.
The issue was caused by converting the depth frame unit byte by byte, but the frame is encoded in 16UC1.
Since there is no need to do unit conversion on DS400 series(unit = 0.001), so this issue only appears on SR300 camera(unit = 0.000124987).
This PR has been verified on my side with SR300. If you agree with this modification, please help me to verify it on DS400 series.
If there is any suggestion for this PR, please feel free to advise me.
Thanks again! Hope this helps :)
Alan