Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mesh and urdf for D435 #404

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

Affonso-Gui
Copy link
Contributor

Collada file is the conversion of the official STEP file.
Other files use the same template as r430 and r415, with measures from the data sheet.

Can be tested with: roslaunch realsense2_camera view_d435_model.launch

Solves #400.

@mattcurf
Copy link

mattcurf commented Jul 9, 2018

Would love to see this merged 👍

@felixvd
Copy link

felixvd commented Jul 12, 2018

Works great, tested it in our simulation.

d435_2
d435_1
(The material doesn't appear in Gazebo)

Would propose moving all the properties and material definitions inside the macro, because they can pollute the global namespace otherwise. I would also add a "prefix" parameter so that multiple cameras can be used, but that goes for the other cameras in this package as well and is a separate issue.

@dorodnic
Copy link
Contributor

@Affonso-Gui this is great, thank you very much.
Will be merged soon, we might look into implementing the suggestion from @felixvd before merging.

@dorodnic dorodnic requested a review from doronhi July 12, 2018 07:05
@doronhi doronhi merged commit ba08fdb into IntelRealSense:development Jul 16, 2018
@waiyc
Copy link

waiyc commented Jul 18, 2018

Hi, thanks for adding the d435 model into gazebo ! However, is there any way that I can publish the image data captured from the simulated camera in gazebo?

The closest reference code for this purpose that I manage to find is R200

The part that confused me most is the Gazebo reference parameters.
Is the parameters used by D435 in librealsense2.so same as the parameters used by R200 in librealsense_gazebo_plugin.so parameters.

@Affonso-Gui Affonso-Gui deleted the add_d435_urdf branch July 18, 2018 07:48
@felixvd
Copy link

felixvd commented Jul 19, 2018

That is outside the scope of this issue, but we also use the same repo for our gazebo simulation, so we would appreciate an update with newer realsense models. The camera parameters of the R200 are absolutely not the same as for the D435.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants