Metadata related fixes (Rebased) #107
Conversation
|
@xzhangxa Could you please review? |
- Make metadata buffer smaller so copy on it could waste less CPU; - IR channel changed from 2 SerDes configs (Y8_Y8I, Y12I) to 3 configs (Y8, Y8I, Y12I), and Y8/Y8I configs enabled metadata datatype, the 2 datatypes per channel limitation is still respected while we could have metadata on IR Y8 and Y8I; - Enable metadata for IR, /dev/video5 will be IR metadata node; - Y12I doesn't have metadata, the metadata node /dev/video5 will output no data when the format is set to Y12I. - Metadata related code refactoring in MC/VI driver: cleanup, move related code into one place, get config from dt instead of hardcode. Signed-off-by: Xin Zhang <xin.x.zhang@intel.com> Signed-off-by: Shikun Ding <shikun.ding@intel.com> Signed-off-by: Junze Wu <junze.wu@intel.com>
|
Hi @dmipx @ev-mp, this was not merged so I guess it's your decision not having metadata for IR (Y8, Y8I) stream. However there were a few changes are useful no matter enabling metadata of IR or not: the VI code change cleanup, reading config from device tree than hardcode, less copy size for metadata etc. It's still nice to have even we turn off metadata for IR. So is this metadata of IR needed for future release, or not at all? We're doing a lot of device tree changes for the multi-D457 and some changes in this PR are still good to use, so we'd like to know this feature is still needed later? If no we will just move some parts of this. |
|
@xzhangxa there is many changes, we will need to do a thorough verification of everything. it will be better to split every orthogonal cchanges to different PR's so we can merge modifications step-by-step. |
Yes totally agree, we should split this patch, there was history about this patch then and it gradually grew this big. Just a few questions: the metadata for IR feature needed or not? In the following PRs do we need to update for both JetPack 4.6.1 and 5.0.2, or 4.6.1 will be frozen and only 5.0.2 to be updated? |
|
Close this since the IR MD feature is not needed and other useful code changes are already in JetPack 5 branch and following PRs. |
|
Actually IR metadata is a good feature, we just didn't had the bandwidth to verify and review it.. |
|
The code was for JetPack 4.6.1 at the time so it's only applicable for 4.6.1. For current JetPack-5.0.2 branch, a little refactor is needed; for #144 the serdes code is changed a lot but actually it makes it easier to enable IR MD with a few code changes (though we didn't try/test it). |
This PR is basically #94 rebased on top of #105. Conflicts that occur in max9295.c and max9296.c have been resolved.