Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSO-18310: d4xx: stderr is stall on printk #112

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

dmipx
Copy link
Contributor

@dmipx dmipx commented Jun 13, 2022

Change dev_err with dev_info where no error cause as
stderr is unbuffered causing stall on printk
The printk results in I2C call taking 8000usec to run vs 40usec when the printk is replaced with info-level log

  • Bump d4xx version to 1.0.1.11

This commit addressing following ticket:

Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com

Change dev_err with dev_info where no error cause as
stderr is unbuffered causing stall on printk

This commit addressing following ticket:
	DSO-18310
	https://rsjira.intel.com/browse/DSO-18310
	[D457][LRS][Pipe] First frame delay When streaming Pipe is always 3-6 seconds

Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com
Copy link
Collaborator

@ev-mp ev-mp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you check if we do have similar dev_err instead of dev_info in other part of the driver?

Copy link
Collaborator

@xzhangxa xzhangxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's a good chance to clean up all the unnecessary logs in d4xx. d4xx has way too many prints, some are even not necessary for info level.

@dmipx
Copy link
Contributor Author

dmipx commented Jun 14, 2022

we will change all unnecessary info to debug at some time..

@ev-mp ev-mp merged commit 8a87cc2 into IntelRealSense:master Jun 14, 2022
dmipx referenced this pull request in dmipx/realsense_mipi_platform_driver_priv Jun 15, 2022
This commit addressing following tickets:
 - DSO-18280 - possible solution
	https://rsjira.intel.com/browse/DSO-18280
	[D457][Hard Failure] Depth and IR Sensor Fails to start after several thousand iterations of Random Mix Stability

This PR is bundled with #112, d4xx version 1.0.1.11
This resolution was introduced in past d4xx version 1.0.1.5 PR #83
kernel/nvidia/0042-Add-sleep-hack-back-to-prevent-regression.patch
IntelRealSense/realsense_mipi_platform_driver#83

and removed in PR #104
kernel/nvidia/0056-Bump-to-version-1.0.1.8.patch
IntelRealSense/realsense_mipi_platform_driver#104

Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
@dmipx dmipx deleted the DSO-18310 branch January 31, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants