fix: allow trusted players to remove books from lecterns while lectern-read-book flag is true #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should probably be a separate flag or something tbh, or come under a different flag as it's altering the block |
The flags description is currently saying: "Prevent players taking books from lecterns.". Entering and actually reading the books inside a lectern has to be done by setting the use flag for lecterns. I think that this is more of a name issue right now or what else comes up to your mind? |
Tamikaschu
force-pushed
the
fix/lectern-read-book-flag
branch
from
3258912 to
3984777
Compare
dordsor21
approved these changes
Mar 20, 2024
NotMyFault
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4323