Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare to update branch to main #33

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Conversation

BenjaminMichaelis
Copy link
Member

@BenjaminMichaelis BenjaminMichaelis commented Jan 27, 2022

Fixes #32

@BenjaminMichaelis
Copy link
Member Author

After merging, is it ok to switch default branch from master to main? @Keboo

@Keboo
Copy link
Member

Keboo commented Jan 27, 2022

No objections, just double check to make sure any branch policies are also recreated.

@BenjaminMichaelis
Copy link
Member Author

@Keboo any idea on why this continuous integration won't finish? I can't merge until it does

@Keboo
Copy link
Member

Keboo commented Jan 28, 2022

ouch, that looks like it is pointed at a really old appveyor pipelines (long since dead). I removed the web hook for it

@Keboo
Copy link
Member

Keboo commented Jan 28, 2022

There, removed the appveyor status check requirement. Looks like just the build failure is blocking now.

@BenjaminMichaelis
Copy link
Member Author

@Keboo Looks like the last build on main was already failing so probably due to a previous issue as the issues listing for failure are the same as the previous build on main so I could just keep the failure and merge and just switch the branches since it seems like this project isn't being kept the most up to date unless we want to try and fix it first.

@Keboo
Copy link
Member

Keboo commented Jan 28, 2022

I am fine with that, but lets log an issue to get it fixed.

@BenjaminMichaelis BenjaminMichaelis merged commit 7c04e74 into master Jan 28, 2022
@BenjaminMichaelis BenjaminMichaelis deleted the PrepForBranchToMain branch January 28, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename default branch to main
2 participants