chore(reminder): in ReminderRemoteDataSource remove return from metho…

…d createNewReminderForLesson
IntelligentBackpack · Jul 11, 2023 · 5afd364 · 5afd364
1 parent 17cd86d
commit 5afd364
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...c/main/kotlin/com/intelligentbackpack/reminderdata/datasource/ReminderRemoteDataSource.kt b/...c/main/kotlin/com/intelligentbackpack/reminderdata/datasource/ReminderRemoteDataSource.kt
@@ -55,9 +55,8 @@ interface ReminderRemoteDataSource {
      * @param email the email of the student.
      * @param lesson the lesson.
      * @param isbn the isbn of the book.
-     * @return the id of the reminder.
      */
-    suspend fun createNewReminderForLesson(email: String, lesson: Lesson, isbn: String): String
+    suspend fun createNewReminderForLesson(email: String, lesson: Lesson, isbn: String)
 
     /**
      * Deletes the reminder for the given lesson.

diff --git a/...in/kotlin/com/intelligentbackpack/reminderdata/datasource/ReminderRemoteDataSourceImpl.kt b/...in/kotlin/com/intelligentbackpack/reminderdata/datasource/ReminderRemoteDataSourceImpl.kt
@@ -52,11 +52,9 @@ class ReminderRemoteDataSourceImpl(
         )
     }
 
-    override suspend fun createNewReminderForLesson(email: String, lesson: Lesson, isbn: String): String {
+    override suspend fun createNewReminderForLesson(email: String, lesson: Lesson, isbn: String) {
         val response = calendarApi.createReminderForLesson(createJsonForReminder(email, lesson, isbn)).execute()
-        if (response.isSuccessful) {
-            return response.body()?.message ?: ""
-        } else {
+        if (!response.isSuccessful) {
             throw DownloadException(ErrorHandler.getError(response))
         }
     }