Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidated files to SFC, improved naming conventions #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

miller-kevin
Copy link

ES6 conversion, Vue SFC, changed naming conventions to be more clear, vuified some things that were vanilla js

@jkalbhenn
Copy link
Contributor

hi and thank you for the contribution that i will soon probably merge, and sorry for the late response. i havent found the time yet to do a quick check, only thing that comes to mind is that the original version was built as separate files instead of SFC so that no Webpack/Build-Tool environment is needed and it can be used anywhere right away. i may replace the current code with the SFC

@miller-kevin
Copy link
Author

No rush. I converted it to an SFC because I'll be using the SFC version in my application and felt like I should share.

Using Vue without a build tool would be a crazy hindrance and I couldn't imagine not adding one haha.

You don't have to replace the old one, but the SFC will be most Vue user's preference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants