Fix ruleset XML #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Apr 15, 2023
Comment on lines
-450
to
+445
| <element key="back" value="redirect()->back"/> | ||
| <element key="back" value="redirect()->back"/> |
There was a problem hiding this comment.
This was a syntax error.
alies-dev
approved these changes
Apr 15, 2023
That is not your opinion, that is a fact! |
|
I hope this standard will not change more frequently than once a quarter. |
no, we used this ruleset for years for our main project (private repo), with very small changes all this time. By starting using it on other repositories we have find some issues, fix them and that's it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1 (review)
Mainly done with
sed -i -e 's#^\(\s\+\)\(<.\+/>\)\(<!-- .\+ -->\)$#\1\3\n\1\2#' IxDFCodingStandard/ruleset.xml