-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specification of Data.ext.segtax #65
Add specification of Data.ext.segtax #65
Conversation
"segtax": 3 | ||
}, | ||
"segment": [ | ||
{ "id": 1001 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AdCOM represents user.data.segment.id
as a string. I think we would all prefer that id be an int. Both IAB taxonomies (content and audience) represent segments with a "unique id" which as far as I can tell equals a int between 1-1,668.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out, id
is indeed a string. I will fix.
We should include link to location where the segtax IDs are enumerated and maintained. If that is still pending , we should temporarily define standard ids here with which will help industry get started. |
Is this ready to merge? I'd like to start the process of asking for enumerated 5XX values for a couple custom segmentations we are ready to start putting in bid requests. |
Hi @patmmccann -- no, there is one remaining item, to understand where the list will be. I understand it'll be in this repo somewhere, and need the IAB team to confirm. |
appears to be here https://github.com/InteractiveAdvertisingBureau/AdCOM/pull/22/files |
To be even more precise, here - https://github.com/InteractiveAdvertisingBureau/AdCOM/blob/master/AdCOM%20v1.0%20FINAL.md#list--category-taxonomies- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for adding the table for all available taxonomies
No description provided.