Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specification of Data.ext.segtax #65

Merged
merged 6 commits into from
Jul 27, 2021

Conversation

simontrasler
Copy link

No description provided.

"segtax": 3
},
"segment": [
{ "id": 1001 },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdCOM represents user.data.segment.id as a string. I think we would all prefer that id be an int. Both IAB taxonomies (content and audience) represent segments with a "unique id" which as far as I can tell equals a int between 1-1,668.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out, id is indeed a string. I will fix.

@abhinavsinha001
Copy link
Contributor

We should include link to location where the segtax IDs are enumerated and maintained. If that is still pending , we should temporarily define standard ids here with which will help industry get started.

@patmmccann
Copy link
Contributor

Is this ready to merge? I'd like to start the process of asking for enumerated 5XX values for a couple custom segmentations we are ready to start putting in bid requests.

@simontrasler
Copy link
Author

Is this ready to merge? I'd like to start the process of asking for enumerated 5XX values for a couple custom segmentations we are ready to start putting in bid requests.

Hi @patmmccann -- no, there is one remaining item, to understand where the list will be. I understand it'll be in this repo somewhere, and need the IAB team to confirm.

@patmmccann
Copy link
Contributor

@amitshetty
Copy link
Contributor

appears to be here https://github.com/InteractiveAdvertisingBureau/AdCOM/pull/22/files

To be even more precise, here - https://github.com/InteractiveAdvertisingBureau/AdCOM/blob/master/AdCOM%20v1.0%20FINAL.md#list--category-taxonomies-

Copy link
Contributor

@jdwieland8282 jdwieland8282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding the table for all available taxonomies

@amitshetty amitshetty merged commit 15eb2b5 into InteractiveAdvertisingBureau:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants