Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gpp addition #22

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Gpp addition #22

merged 2 commits into from
Nov 1, 2022

Conversation

robhazan
Copy link
Collaborator

@robhazan robhazan commented Nov 1, 2022

Pulling this into the develop branch.

@robhazan robhazan merged commit 7fe2a89 into develop Nov 1, 2022
@robhazan robhazan deleted the gpp-addition branch November 1, 2022 21:01
@@ -827,7 +827,7 @@ This object describes the nature and behavior of the entity that is the source o

### 3.2.3 - Object: Regs <a name="objectregs"></a>

This object contains any legal, governmental, or industry regulations that the sender deems applicable to the request. See Section 7.5 for more details on the flags supporting Coppa, GDPR and CCPA.
This object contains any legal, governmental, or industry regulations that the sender deems applicable to the request. See Section 7.5 for more details on the flags supporting Coppa, GDPR and others.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COPPA is also an acronym.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would delete the word 'any'; I'm not sure it adds any clarity.

<tr>
<td><code>gpp_sid</code></td>
<td>integer array</td>
<td>Array of the section(s) of the string which should be applied for this transaction. Generally will contain one and only one value, but there are edge cases where more than one may apply. GPP Section 3 (Header) and 4 (Signal Integrity) do not need to be included. See the <a href="https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Sections/Section%20Information.md">GPP Section Information</a> for more details.</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For completeness, does this mean the caller may include 3 or 4 or both in this list, and the receiver should therefore ignore these values when they appear?

If sections 3 and 4 are not to be mentioned (because they are required), we can strengthen the language here from "do not need" to "are not".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Simon here, it's unclear what to do with section 3 if we have it from this language

<td><code>gpp_sid</code></td>
<td>integer array</td>
<td>Array of the section(s) of the string which should be applied for this transaction. Generally will contain one and only one value, but there are edge cases where more than one may apply. GPP Section 3 (Header) and 4 (Signal Integrity) do not need to be included. See the <a href="https://github.com/InteractiveAdvertisingBureau/Global-Privacy-Platform/blob/main/Sections/Section%20Information.md">GPP Section Information</a> for more details.</td>
</tr>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@drpaulfarrow

Would applicable sections and the string be sufficient in your view? I saw you guys were asking for additional info beyond the string.

In general the applicable section to me feels quite incomplete. At the time of a bid request each section may have status does apply, does not apply, or may apply but we don't yet know in examples such as the bid request occurred before the cmp determined the scope. I am not sure a list of applicable sections is useful without another flag indicating if the string is complete yet or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants