Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transaction and request ID clarifications #88

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

transaction and request ID clarifications #88

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e584eeb
transaction and request ID clarifications
robhazan Dec 21, 2023
d0a4b17
matching oRTB3 language
robhazan Dec 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 2.6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -855,7 +855,7 @@ This object describes the nature and behavior of the entity that is the source o
<tr>
<td><code>tid</code></td>
<td>string; recommended</td>
<td>Transaction ID that must be common across all participants in this bid request (e.g., potentially multiple exchanges).</td>
<td>Transaction ID, generated by the publisher or agent originating an ad request for the end user, that must be common across all participants in this bid request (e.g., all exchanges participating in a header bidding or similar publisher-centric broadcast scenario). It should not be assumed that this ID uniquely identifies 1 biddable impression opportunity, unless that's all that exists on the bid request. Any podded audio/video bid request or multi-impression bid request may reflect multiple concurrent biddable impression opportunities. To uniquely identify those, consider using <a href="https://github.com/InteractiveAdvertisingBureau/openrtb/blob/master/extensions/community_extensions/per-imp-tids.md">per-impression transaction IDs</a>.</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would consider adding:

This should not be added by middlemen, with better wording. We've found some people don't support the tid on their request and then make one up when they make a request to the next entity.

</tr>
<tr>
<td><code>pchain</code></td>
Expand Down Expand Up @@ -2740,7 +2740,7 @@ This object is associated with a `SupplyChain` object as an array of nodes. Thes
<tr>
<td><code>rid</code></td>
<td>string</td>
<td>The OpenRTB RequestId of the request as issued by this seller.</td>
<td>The OpenRTB RequestId of the bid request as issued by the advertising system associated with this Supply Chain Node.</td>
Copy link
Collaborator

@simontrasler simontrasler Jan 2, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend putting this through in a separate PR. I have more questions about the need to change this one, since it's possible vendors are relying on the previous definition.

</tr>
<tr>
<td><code>name</code></td>
Expand Down