Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading font file from .dfmod #2579

Merged

Conversation

Jagget
Copy link
Collaborator

@Jagget Jagget commented Feb 10, 2024

  • I changed ModManager load priority, so now it initialized before DaggerfallUI.
  • Init logic of the ModManager was moved from Start() to Awake()

image

@KABoissonneault
Copy link
Collaborator

I understand that shipping fonts in dfmods is one of the last steps to let a localization mod ship only a single file. I do think we can prioritize this for DFU 1.1. That font is needed any time text is shown to the user.

Can you send me a font file I can use for testing this? I have only one concern for this change. I wanna make sure the font is properly removed if the user disables the mod and restarts the game. I'm a bit hesitant to introduce more mods that affect the Launcher, after the mod "Mute Launcher Music" caused user confusion.

image

@Jagget
Copy link
Collaborator Author

Jagget commented Feb 19, 2024

shipping fonts in dfmods is one of the last steps to let a localization mod ship only a single file

BIOGs. There's always BIOGs...

Here's the dfmod with fonts attached. For testing fonts.zip

@KABoissonneault KABoissonneault added this to the DFU 1.1.1 milestone Apr 12, 2024
@KABoissonneault
Copy link
Collaborator

I removed the comment from ModManager.Awake. No need to put comments about the "past state" of the code in the code, you can keep that in the commit message and PR review comments.

I didn't know about Script Execution Order settings. Here's an example of the DFU execution order values after this PR.
image

Some things I'm noticing while testing.

  • Disabling the mod system still keeps the font active

image

That one I don't really blame on the PR. The code in ModManager that checks for if (!DaggerfallUnity.Settings.LypyL_ModSystem) destroys this but does not end the initialization of the mod manager. It seems like disabling the mod system is pretty broken to begin with.

  • Starting the main menu with the "fonts" mod disabled then enabling the "fonts" mod will not apply the font on the main screen, but it will apply it on new UI screens like the Settings. Might be a bit complicated to fix, and it's not that bad

Overall, I think it's good enough for v1.1.1. It should reduce the number of files that localization mods have to ship

@KABoissonneault
Copy link
Collaborator

I'd really like to get this merged for the v1.1.1 official release soon.

@KABoissonneault KABoissonneault merged commit 0038a1e into Interkarma:master May 10, 2024
@Jagget Jagget deleted the Support-loading-font-file-from-.dfmod branch May 12, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants