Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vision model use tp number of gpu #1854

Merged
merged 8 commits into from
Jul 5, 2024
Merged

vision model use tp number of gpu #1854

merged 8 commits into from
Jul 5, 2024

Conversation

irexyc
Copy link
Collaborator

@irexyc irexyc commented Jun 25, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028
Copy link
Collaborator

lvhan028 commented Jul 1, 2024

May update after #1845 (phi3-vision)

@RunningLeon
Copy link
Collaborator

@irexyc may fix conflicts with main branch.

@lvhan028 lvhan028 requested a review from AllentDan July 4, 2024 07:12
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lmdeploy serve api_server /nvme/shared_data/Yi/Yi-VL-6B --tp 2 failed
TypeError: argument of type 'NoneType' is not iterable

lmdeploy/vl/model/yi.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with following models:

  • yi-vl-6b
  • qwen-vl
  • mini-gemini
  • llava
  • internvl

Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 171c9fb into InternLM:main Jul 5, 2024
5 checks passed
@zhulinJulia24 zhulinJulia24 mentioned this pull request Jul 16, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants