Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix Qwen typo #2136

Merged
merged 4 commits into from
Jul 28, 2024
Merged

docs: fix Qwen typo #2136

merged 4 commits into from
Jul 28, 2024

Conversation

ArtificialZeng
Copy link
Contributor

Qwen not QWen

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Qwen not QWen
@lvhan028
Copy link
Collaborator

May also update the chinese version README

@ArtificialZeng
Copy link
Contributor Author

May also update the chinese version README

you changed it by yourself

Copy link
Collaborator

@zhyncs zhyncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chinese doc needs to be updated too.

@ArtificialZeng
Copy link
Contributor Author

Chinese doc needs to be updated too.

It's all done by yourself. Can you still accept this pr? I'll be working on this project further. pls.

@zhyncs
Copy link
Collaborator

zhyncs commented Jul 27, 2024

Sorry nope. This change is not difficult. What is the reason you are unable to make it here? We need to maintain consistency between the Chinese and English documents.

@ArtificialZeng
Copy link
Contributor Author

Sorry nope. This change is not difficult. What is the reason you are unable to make it here? We need to maintain consistency between the Chinese and English documents.

Yes! you are absolutely right. 1st, the amendment is easy. But that's all I got.
it such a great honor for such a big-shot comment on this insignificant fix.
nice talking to you. I wish one day I'll contribute more

@ArtificialZeng
Copy link
Contributor Author

Sorry nope. This change is not difficult. What is the reason you are unable to make it here? We need to maintain consistency between the Chinese and English documents.

I have made the change as you prescribed. Your tutor and your projects have taught me a lot. Thank you, little bro and little sis.
hope your project will be super famous.

Sincere,
Zeng

@zhyncs
Copy link
Collaborator

zhyncs commented Jul 27, 2024

May you also update docs/zh_cn/supported_models/supported_models.md and docs/en/supported_models/supported_models.md as well? Thank you very much.

@ArtificialZeng
Copy link
Contributor Author

docs/en/supported_models/supported_models.md

All done! 🎉 You truly are a meticulous and professional expert! Just to let you know, This experience has greatly expanded my knowledge of GitHub, and I appreciate your hard work in maintaining such an impressive project. Looking forward to future collaborations!

Copy link
Collaborator

@zhyncs zhyncs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhyncs zhyncs requested review from lvhan028 and AllentDan July 27, 2024 05:03
@zhyncs zhyncs changed the title Update README.md docs: fix Qwen typo Jul 27, 2024
@lvhan028 lvhan028 added the documentation Improvements or additions to documentation label Jul 28, 2024
@lvhan028 lvhan028 merged commit fc6f286 into InternLM:main Jul 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants