Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix runtime error when using dynamic scale rotary embed for InternLM2… #2212

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

CyCle1024
Copy link
Collaborator

… on ascend 910b

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

support dynamic scale rotary embedding on InternLM2 with ascend 910b hardware.

Modification

Please briefly describe what modification is made in this PR.

modify lmdeploy/pytorch/kernels/dipu/apply_rotary_pos_emb.py to support old and new rotary_emb by checking cos dim.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 requested a review from grimoire August 1, 2024 07:13
@lvhan028 lvhan028 added the Bug:P1 label Aug 1, 2024
@lvhan028 lvhan028 merged commit 543e328 into InternLM:main Aug 2, 2024
4 of 5 checks passed
@CyCle1024 CyCle1024 deleted the fix-internlm2-910b-rotary-emb branch August 8, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants