Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variable to control SILU fusion #2343

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

lzhangzz
Copy link
Collaborator

For debugging purpose. The fused SILU is acting directly on F32 accumulator (without casting to F16 back and forth) and the result is slightly different from non-fused version (albeit having higher precision)

Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 6f81013 into InternLM:main Aug 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants