Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor turbomind (1/N) #2352

Merged
merged 6 commits into from
Aug 22, 2024
Merged

Conversation

lzhangzz
Copy link
Collaborator

  • Correct the relationship between LlamaBatch and LlamaV2
  • Clean up ctor parameter passing
  • Set device id before dtor

@lvhan028 lvhan028 self-requested a review August 21, 2024 13:36
src/turbomind/models/llama/LlamaV2.cc Outdated Show resolved Hide resolved
src/turbomind/models/llama/LlamaV2.cc Outdated Show resolved Hide resolved
Copy link
Collaborator

@lvhan028 lvhan028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 requested a review from irexyc August 22, 2024 07:28
@lzhangzz lzhangzz merged commit b78c8b9 into InternLM:main Aug 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants