[ci] add daily test's coverage report #2401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zhulinJulia24
commented
Aug 30, 2024
•
zhulinJulia24
commented
- add auto_gptq testcase
- add coverage statistics
- change interface test model into internlm2.5
- add order check of /v1/completions interface
- bugfix:
- fix codellama chat spilter
- fix benchmark function testcase
lvhan028
reviewed
Aug 30, 2024
| @@ -104,7 +104,7 @@ def command_test(config, | |||
| file.writelines('reproduce command chat: ' + ' '.join(cmd) + '\n') | |||
|
|
|||
| spliter = '\n\n' | |||
| if 'codellama' in model.lower() and ' chat ' in cmd: | |||
| if 'codellama' in model.lower() and 'serve' not in ' '.join(cmd): | |||
There was a problem hiding this comment.
why there is a special case about "'serve' not in ' '.join(cmd)"
There was a problem hiding this comment.
why there is a special case about "'serve' not in ' '.join(cmd)"
currently, if use lmdeploy chat $codellama_model, use enter !! to end the input >>>
if use lmdeploy serve api_server http://localhost:23333 after apt_server is started, use double enter to end input >>>
I use this conditional statement to distinguish two situations. I did not notice cmd is a string list, fix this condition statement. Both 'chat' in ' '.join(cmd) and 'serve' not in ' '.join(cmd) are OK.
lvhan028
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.