Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add max_log_len option to control length of printed log #2478

Merged
merged 6 commits into from
Sep 20, 2024
Merged

Add max_log_len option to control length of printed log #2478

merged 6 commits into from
Sep 20, 2024
+115 −139

Conversation

lvhan028
Copy link
Collaborator 

lmdeploy serve api_server <model_path> --max-log-len 100

@irexyc
Copy link
Collaborator

irexyc commented Sep 19, 2024

Could we add filename and lineno to the log like https://github.com/vllm-project/vllm/blob/855c8ae2c9a4085b1ebd66d9a978fb23f47f822c/vllm/logger.py#L19 ? The current log information cannot determine where it is printed

AllentDan
AllentDan approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@AllentDan AllentDan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 8b9f6ab into InternLM:main Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AllentDan AllentDan AllentDan approved these changes

@irexyc irexyc irexyc approved these changes

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lvhan028 @irexyc @AllentDan