Improve proxy server usage #2488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lmdeploy/cli/serve.py lmdeploy/serve/openai/api_server.py
|
Let's add another CLI for lmdeploy serve proxy --server-name {server_name} --server-port {server_port} --strategy "min_expected_latency"default |
lvhan028
reviewed
Sep 22, 2024
lvhan028
reviewed
Sep 22, 2024
lvhan028
reviewed
Sep 22, 2024
docs/en/llm/proxy_server.md
Outdated
|
|
||
| ```shell | ||
| curl -X 'POST' \ | ||
| 'http://localhost:10086/nodes/remove?node_url=http://0.0.0.0:23333' \ |
There was a problem hiding this comment.
Which is a more conventional way, "remove/?node_url" or set the parameter in -d field?
There was a problem hiding this comment.
Both worked, the command was from swagger UI.
lvhan028
reviewed
Sep 23, 2024
| @@ -40,6 +40,9 @@ class VariableInterface: | |||
| session_id: int = 0 | |||
| api_keys: Optional[List[str]] = None | |||
| request_hosts = [] | |||
| # following are for registering to proxy server | |||
| proxy_url: Optional[str] = None | |||
| api_server_url: Optional[str] = None | |||
There was a problem hiding this comment.
Is it necessary? Can we use http://{server_ip}:{server_port} instead
There was a problem hiding this comment.
It is a global variable. VariableInterface.api_server_url = f'{http_or_https}://{server_name}:{server_port}'
lvhan028
approved these changes
Sep 23, 2024
RunningLeon
reviewed
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.