Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[maca] add maca backend support. #2636

Merged
merged 4 commits into from
Oct 24, 2024
Merged

[maca] add maca backend support. #2636

merged 4 commits into from
Oct 24, 2024

Conversation

Reinerzhou
Copy link
Contributor

Motivation

add maca backend support.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@Reinerzhou Reinerzhou marked this pull request as draft October 23, 2024 05:54
@jinminxi104 jinminxi104 marked this pull request as ready for review October 23, 2024 05:58
@lvhan028 lvhan028 requested a review from jinminxi104 October 23, 2024 07:53
@jinminxi104 jinminxi104 requested a review from CyCle1024 October 24, 2024 02:14
grimoire
grimoire approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@grimoire grimoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@QwertyJack
Copy link
Contributor

Could you please kindly explain what maca is?

@lvhan028 lvhan028 added the enhancement New feature or request label Oct 24, 2024
@lvhan028
Copy link
Collaborator

沐曦

Could you please kindly explain what maca is?

@lvhan028 lvhan028 merged commit 321b940 into InternLM:main Oct 24, 2024
5 checks passed
@Reinerzhou
Copy link
Contributor Author

Could you please kindly explain what maca is?

A backend to support inference on muxi platform， just like ascend and cuda that has supported in lmdeploy。

@Reinerzhou Reinerzhou deleted the zhousl/maca_dev branch November 18, 2024 10:28
@Reinerzhou Reinerzhou restored the zhousl/maca_dev branch November 18, 2024 10:28
@Reinerzhou Reinerzhou deleted the zhousl/maca_dev branch November 18, 2024 10:28
@Reinerzhou Reinerzhou restored the zhousl/maca_dev branch November 18, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinminxi104 jinminxi104 jinminxi104 approved these changes

@grimoire grimoire grimoire approved these changes

@lvhan028 lvhan028 Awaiting requested review from lvhan028

@CyCle1024 CyCle1024 Awaiting requested review from CyCle1024

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reinerzhou @QwertyJack @lvhan028 @grimoire @jinminxi104