Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix supported model list in ascend graph mode #2669

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

jinminxi104
Copy link
Collaborator

  1. Since latest InternLM2 uses NTK in RoPE, graph mode cannot support it for now. llama3-8B is tested in graph mode.
  2. Since we cannot distinguish between llama3 and llama3.1, warning message always show in graph mode.
  3. Since graph mode is BC-breaking feature, we made the message more noticeable.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@jinminxi104 jinminxi104 changed the title fix supported model list of ascend graph mode fix supported model list in ascend graph mode Oct 28, 2024
@lvhan028 lvhan028 merged commit f5189ce into InternLM:main Oct 28, 2024
4 of 5 checks passed
AllentDan pushed a commit to AllentDan/lmdeploy that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants