Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better tp exit log. #2677

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Better tp exit log. #2677

merged 2 commits into from
Nov 4, 2024

Conversation

grimoire
Copy link
Collaborator

Only show log if exitcode > 0.

RunningLeon
RunningLeon approved these changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@RunningLeon RunningLeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhulinJulia24
Copy link
Collaborator

LGTM

test

CUDA_VISIBLE_DEVICES=0,1,2,3 python3 benchmark/profile_throughput.py /nvme/qa_test_models/datasets/ShareGPT_V3_unfiltered_cleaned_split.json /nvme/qa_test_models/meta-llama/Meta-Llama-3-1-70B-Instruct  --concurrency 256 --num-prompts 1000 --quant-policy 0 --tp 4 --backend pytorch

CUDA_VISIBLE_DEVICES=0,1,2,3 lmdeploy chat /nvme/qa_test_models/meta-llama/Meta-Llama-3-1-8B-Instruct --tp 4 --backend pytorch

no error log when exit

zhulinJulia24
zhulinJulia24 approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@zhulinJulia24 zhulinJulia24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lvhan028 lvhan028 merged commit 20de959 into InternLM:main Nov 4, 2024
5 checks passed
lvhan028 pushed a commit that referenced this pull request Nov 5, 2024
@grimoire @lvhan028
better tp exit log (#2677)
36bf28f
AllentDan pushed a commit to AllentDan/lmdeploy that referenced this pull request Nov 13, 2024
@grimoire @AllentDan
better tp exit log (InternLM#2677)
7335876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhulinJulia24 zhulinJulia24 zhulinJulia24 approved these changes

@RunningLeon RunningLeon RunningLeon approved these changes

Assignees
No one assigned
Labels
Bug:P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grimoire @zhulinJulia24 @RunningLeon @lvhan028