fix tp exit code for pytorch engine #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grimoire
approved these changes
Nov 6, 2024
lvhan028
reviewed
Nov 6, 2024
| @@ -517,7 +517,8 @@ def _check_context_alive(mp_context: mp.ProcessContext): | |||
| for idx, exitcode in log_procs: | |||
| logger.error(f'TP process {idx} failed with exitcode {exitcode}.') | |||
| # TODO: not safe exit. | |||
There was a problem hiding this comment.
It's safer to me. @grimoire can we remove this comment?
lvhan028
approved these changes
Nov 7, 2024
wzk1015
pushed a commit
to wzk1015/lmdeploy
that referenced
this pull request
Nov 7, 2024
[WIP] support Mono-InternVL; fix typos [debug] mono-internvl test script finish mono-internvl delete test files fix tp exit code for pytorch engine (InternLM#2718) docs for mono-internvl
AllentDan
pushed a commit
to AllentDan/lmdeploy
that referenced
this pull request
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist