Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix assert pad >= 0 failed when inter_size is not a multiple of group… #2740

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

Vinkle-hzt
Copy link
Contributor

@Vinkle-hzt Vinkle-hzt commented Nov 12, 2024

Motivation

fix #2739

Modification

change little in groups_per_rank calculation to make sure the inter_size_padded is greater than the inter_size

BC-breaking (Optional)

None

Use cases (Optional)

None

Copy link
Collaborator

@lzhangzz lzhangzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzhangzz lzhangzz requested a review from lvhan028 November 12, 2024 07:49
@lvhan028
Copy link
Collaborator

Pls resolve linting issues:

pip install pre-commit
cd lmdeploy  # the root dir of lmdeploy repo
pre-commit install
pre-commit run --all-files

@Vinkle-hzt
Copy link
Contributor Author

Vinkle-hzt commented Nov 12, 2024

Pls resolve linting issues:

pip install pre-commit
cd lmdeploy  # the root dir of lmdeploy repo
pre-commit install
pre-commit run --all-files

fix lint error now

@Vinkle-hzt Vinkle-hzt closed this Nov 12, 2024
@Vinkle-hzt Vinkle-hzt reopened this Nov 12, 2024
@lvhan028 lvhan028 merged commit e751708 into InternLM:main Nov 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] assert pad >= 0 failed when inter_size is not a multiple of group_size
3 participants