Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ascend installation adapter #2817

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Add Ascend installation adapter #2817

merged 1 commit into from
Nov 29, 2024

Conversation

zhabuye
Copy link
Contributor

@zhabuye zhabuye commented Nov 26, 2024

Motivation

I hope lmdeploy can be installed directly from source in the Ascend environment, and I have made adaptation modifications for this.

Modification

I have added requirements_ascend and requirements/runtime_ascend.txt compatible with Ascend and included corresponding conditional branches in setup.py so that users can achieve one-click installation in the Ascend environment.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Thank you for your approval!

@lvhan028
Copy link
Collaborator

Hi, @zhabuye
Thank you very much for your contribution
There are some linting errors, which can be fixed by the following:

pip install pre-commit
cd lmdeploy # the root directory of lmdeploy repo code
pre-commit install
pre-commit run --all-files

@zhabuye
Copy link
Contributor Author

zhabuye commented Nov 28, 2024

Hi, @lvhan028
Thank you for your generous assistance. I have corrected the linting errors based on your detailed instructions. However, it appears that the unit tests are not successful. Do you have any insights into this issue? I would greatly appreciate it if you could review it again. Thank you very much!

@lvhan028
Copy link
Collaborator

The unit-test has nothing to do with this PR.
You can ignore it.

@jinminxi104
Copy link
Collaborator

Works on our ascend machine

@lvhan028 lvhan028 merged commit 01f82e0 into InternLM:main Nov 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants