Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lora name and rearange wqkv for internlm2 #2912

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Dec 17, 2024

Motivation

fix lora name and rearange lora of wqkv for internlm2

Modification

  • fix loading lora name with '.' like :
  "target_modules": [
    "attention.wo",
    "attention.wqkv",
    "feed_forward.w1",
    "feed_forward.w3",
    "feed_forward.w2"
  ]
  • rearange lora of wqkv for internlm2

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@lvhan028 lvhan028 requested a review from grimoire December 17, 2024 13:18
@lvhan028 lvhan028 requested a review from AllentDan December 18, 2024 03:57
@RunningLeon
Copy link
Collaborator Author

@zhulinJulia24 fixed requirements in this pr

@lvhan028 lvhan028 merged commit 33f5b19 into InternLM:main Dec 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants