Fix build crash in nvcr.io/nvidia/pytorch:24.06-py3 image #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzhangzz
approved these changes
Dec 27, 2024
lvhan028
approved these changes
Dec 30, 2024
lvhan028
changed the title
zhyncs
reviewed
Dec 30, 2024
| @@ -84,7 +84,7 @@ FastCompare(const T* src, const T* ref, int dims, int bsz, cudaStream_t stream, | |||
| thrust::cuda::par.on(stream), | |||
| zip_iter, | |||
| zip_iter + count, | |||
| [=] __device__(auto tup) { | |||
| [=] __host__ __device__(thrust::tuple<float, float> tup) -> Tuple { | |||
There was a problem hiding this comment.
May we also update with the turbomind repo https://github.com/InternLM/turbomind
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily receiving feedbacks. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Fix 2 bugs
Modification
See #2963
BC-breaking (Optional)
None
Use cases (Optional)
None
Checklist