Fix refreshSDK implementation #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdrianGri
commented
May 10, 2023
Comment on lines
+134
to
+137
| export const refreshSDKAtom = atom(null, (get, set) => { | ||
| set(shouldStartSDKAtom, true); | ||
| stopSDK(); | ||
| }); |
There was a problem hiding this comment.
Not completely necessary to have this abstraction but wanted to add it since that's how we had it before
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Suspecting that this is causing errors related to the infinite refresh loop. Even if it doesn't fix it, our current implementation of refreshing the SDK is wrong because it does not wait for the SDK to stop before starting it again.
What Changed