-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DRep and CC key types #251
Conversation
from the cabal.project file. For now we only support 8107 anyway, and the next compiler with JS support is 96+
This is likley due to `ghc-9.6` linking to a new C runtime lib on Windows for `ghc-9.4` and later.
If fails to build with `ghc-9.6` with an error of "unhandled PEi386 relocation type 14".
* also removes flake-compat
Use `shouldContain` instead of `shouldStartWith`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of minor things noticed but overall looking like good progress
cc: @aleeusgr please see changes here and would love your feedback on the Nix build issues we're still seeing! |
81b67f3
to
82dcd08
Compare
-- | ||
deriveDRepPrivateKey | ||
:: Shelley 'AccountK XPrv | ||
-> Shelley 'DelegationK XPrv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have here 'DRepK
-- | ||
deriveCCColdPrivateKey | ||
:: Shelley 'AccountK XPrv | ||
-> Shelley 'DelegationK XPrv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have here 'CCColdK
-- | ||
deriveCCHotPrivateKey | ||
:: Shelley 'AccountK XPrv | ||
-> Shelley 'DelegationK XPrv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should have here 'CCHotK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we have somewhere decided to use the following derivation paths
1852H/1815H/0H/3/0
for DRep
1852H/1815H/0H/4/0
for CCCold
1852H/1815H/0H/5/0
for CCHot
Correct?
Also it would be good to adjust https://github.com/IntersectMBO/cardano-addresses/blob/master/core/test/Cardano/Address/Style/ShelleySpec.hs
(extend role generator and add golden here)
Finally, cli support would need to be added (of course could be in separate PR)
cherry-picked the commit and finished here #259 |
dependent on #231