Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DRep and CC key types #251

Closed
wants to merge 70 commits into from
Closed

Add DRep and CC key types #251

wants to merge 70 commits into from

Conversation

disassembler
Copy link
Contributor

dependent on #231

@disassembler disassembler changed the base branch from master to erikd/ghc-9.6 June 9, 2024 12:38
Use `shouldContain` instead of `shouldStartWith`.
Copy link
Contributor

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor things noticed but overall looking like good progress

cabal.project Show resolved Hide resolved
command-line/lib/Command/Key/WalletId.hs Show resolved Hide resolved
@Crypto2099
Copy link
Contributor

cc: @aleeusgr please see changes here and would love your feedback on the Nix build issues we're still seeing!

@Anviking Anviking removed their request for review June 10, 2024 15:11
--
deriveDRepPrivateKey
:: Shelley 'AccountK XPrv
-> Shelley 'DelegationK XPrv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have here 'DRepK

--
deriveCCColdPrivateKey
:: Shelley 'AccountK XPrv
-> Shelley 'DelegationK XPrv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have here 'CCColdK

--
deriveCCHotPrivateKey
:: Shelley 'AccountK XPrv
-> Shelley 'DelegationK XPrv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have here 'CCHotK

Copy link
Collaborator

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we have somewhere decided to use the following derivation paths
1852H/1815H/0H/3/0 for DRep
1852H/1815H/0H/4/0 for CCCold
1852H/1815H/0H/5/0 for CCHot
Correct?

Also it would be good to adjust https://github.com/IntersectMBO/cardano-addresses/blob/master/core/test/Cardano/Address/Style/ShelleySpec.hs
(extend role generator and add golden here)
Finally, cli support would need to be added (of course could be in separate PR)

Base automatically changed from erikd/ghc-9.6 to master June 12, 2024 02:16
@paweljakubas
Copy link
Collaborator

cherry-picked the commit and finished here #259

@paweljakubas paweljakubas deleted the sl/drep-cc branch June 24, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants