-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix JS Demo #267
base: master
Are you sure you want to change the base?
Fix JS Demo #267
Conversation
…ble-definition we're seeing after the build process.
…unctions and crc32 hashing functions which were included separately via dedicated JS files previously. Attempting to remove them from build.sh to see if the built files will successfully work afterwards.
I'd like to build this PR locally to check the build result, but I'm getting the same npm ERESOLVE error as the CI: running What should I do instead? |
This build error I believe was due to my local package and lock getting accidentally updated and included in the commit. I've rolled these changes back this morning. For local testing I am making changes and running the same steps as the The "problem" is that the generated file: However, there is still 4 lingering functions that I have not been able to isolate the source of the duplication:
|
@luite I found at least the first three of the "duplicated" functions included as part of the GHCJS library from this shim file: Although, I am uncertain where the other (non-commented as stub) versions of these same functions are being included. |
…es into the compiled outputs.
Ah, some of the offending code (previously imported from |
Thanks, I'll try again and have a look at the build artifacts! Looks like you've found the issues, we've merged some of the JS files into the packages, so they can be removed from the nix build. GHC 9.6 doesn't automatically build/include |
Thanks it builds here now and can run the tests! Just some still failing because |
I've pushed fixes for |
Use the fixes by updating
|
This is not ready for merging yet but seeks to address Issue #264.
Troubleshooting identified the problem as some duplicated functions in the
cardano-addresses-jsapi.esm.js
file due to legacycrypto-wrapper.js
andcrc32.js
which are correctly being pulled in viaemcc
now.There are still a few duplicated functions that need to be traced.