Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 4.0.0 #279

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Bump version to 4.0.0 #279

wants to merge 6 commits into from

Conversation

palas
Copy link
Contributor

@palas palas commented Nov 13, 2024

No description provided.

@palas palas self-assigned this Nov 13, 2024
Copy link
Collaborator

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to update also copyright?
Like : https://github.com/IntersectMBO/cardano-addresses/blob/master/core/cardano-addresses.cabal#L12 ?
etc.

And resolve also #222
and #225 ?

There is also ci/eval not passing that would be good to make green

@Crypto2099
Copy link
Contributor

I am working towards #225 so hopefully we'll have that before we are fully ready for release. I asked about the copyright issue a while back and did not get a clear answer but definitely agree that it should probably be updated given that the repo is now under Intersect ownership/maintenance.

So, still some work to be done but at least we have a PR to start working against for tagging this as a proper release

ChangeLog.md Outdated Show resolved Hide resolved
@abailly
Copy link

abailly commented Dec 12, 2024

Just curious: why bumping major version to 4.0.0? I don't see any breaking changes here, but maybe I am wrong?

@palas
Copy link
Contributor Author

palas commented Dec 18, 2024

@abailly, I felt it was appropriate because there wasn't any release in 2 years, so it seemed quite a big change. But it doesn't have to be a major version. There may end up being breaking changes though, not sure how it is going to unfold.

@abailly
Copy link

abailly commented Dec 18, 2024

I don't have any fetichism about numbers so if 4.0.0 sounds cool, 4.0.0 it is :) We are planning to do such a release soonish with @paweljakubas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants