-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump version to 4.0.0 #279
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to update also copyright?
Like : https://github.com/IntersectMBO/cardano-addresses/blob/master/core/cardano-addresses.cabal#L12 ?
etc.
And resolve also #222
and #225 ?
There is also ci/eval not passing that would be good to make green
I am working towards #225 so hopefully we'll have that before we are fully ready for release. I asked about the copyright issue a while back and did not get a clear answer but definitely agree that it should probably be updated given that the repo is now under Intersect ownership/maintenance. So, still some work to be done but at least we have a PR to start working against for tagging this as a proper release |
Update copyright
Co-authored-by: Adam Dean <63186174+Crypto2099@users.noreply.github.com>
Just curious: why bumping major version to 4.0.0? I don't see any breaking changes here, but maybe I am wrong? |
@abailly, I felt it was appropriate because there wasn't any release in 2 years, so it seemed quite a big change. But it doesn't have to be a major version. There may end up being breaking changes though, not sure how it is going to unfold. |
I don't have any fetichism about numbers so if 4.0.0 sounds cool, 4.0.0 it is :) We are planning to do such a release soonish with @paweljakubas |
No description provided.