Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ScriptDatum in spending scripts optional in accordance with CIP-0069 #575

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Make ScriptDatum in spending scripts optional in accordance with CIP-0069
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - compatible     # the API has changed but is non-breaking

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/make-v3-script-datum-optional branch from 0db5135 to e865569 Compare July 3, 2024 11:59
@palas
Copy link
Contributor

palas commented Jul 5, 2024

FYI: Because we now enforce the use of cabal-gild to format cabal files and, in order to reduce the amount of hassle, I have cherry-picked the appropriate commit into your PR. This will make the cabal-gild CI check pass for the PR. The commit should be discarded automatically as soon as you either rebase or merge the PR (since it is already in the main branch). Feel free to discard it if you want, but that will make the new required action to fail until you rebase.

@palas
Copy link
Contributor

palas commented Jul 6, 2024

FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch here: backup/jordan/make-v3-script-datum-optional

@palas palas force-pushed the jordan/make-v3-script-datum-optional branch 3 times, most recently from cb225c0 to 37b6157 Compare July 11, 2024 16:22
I.E the datum is no longer required in spending scripts
@Jimbo4350 Jimbo4350 force-pushed the jordan/make-v3-script-datum-optional branch from 37b6157 to e966600 Compare July 19, 2024 09:42
@Jimbo4350 Jimbo4350 marked this pull request as ready for review July 19, 2024 09:42
@Jimbo4350 Jimbo4350 enabled auto-merge July 19, 2024 09:56
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Jul 19, 2024
Merged via the queue into main with commit 83122f7 Jul 19, 2024
26 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/make-v3-script-datum-optional branch July 19, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants