Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mention about when to merge release PR #576

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jul 3, 2024

Changelog

- description: |
    Add mention about when to merge release PR.
    Move tagging section after CHaPing.
    Add build badges to README.md
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
   - documentation  # change in code docs, haddocks...

Context

Rendered:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas requested a review from a team as a code owner July 5, 2024 17:51
@palas
Copy link
Contributor

palas commented Jul 5, 2024

FYI: Because we now enforce the use of cabal-gild to format cabal files and, in order to reduce the amount of hassle, I have cherry-picked the appropriate commit into your PR. This will make the cabal-gild CI check pass for the PR. The commit should be discarded automatically as soon as you either rebase or merge the PR (since it is already in the main branch). Feel free to discard it if you want, but that will make the new required action to fail until you rebase.

@palas
Copy link
Contributor

palas commented Jul 6, 2024

FYI: I have rebased your branch because we have done changes to the formatting. I have made a copy of the unrebased branch here: backup/mgalazyn/doc/add-tips-to-releasing-doc

@palas palas force-pushed the mgalazyn/doc/add-tips-to-releasing-doc branch 2 times, most recently from 57fbeb8 to ce8cdb2 Compare July 6, 2024 03:12
@carbolymer carbolymer force-pushed the mgalazyn/doc/add-tips-to-releasing-doc branch from ce8cdb2 to 6392d89 Compare July 9, 2024 11:13
@carbolymer carbolymer force-pushed the mgalazyn/doc/add-tips-to-releasing-doc branch from 6392d89 to 4c7438d Compare July 9, 2024 11:23
@carbolymer carbolymer added this pull request to the merge queue Jul 11, 2024
Merged via the queue into main with commit c51e413 Jul 11, 2024
26 checks passed
@carbolymer carbolymer deleted the mgalazyn/doc/add-tips-to-releasing-doc branch July 11, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants