Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate createAndValidateTransactionBody #597

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Deprecate createAndValidateTransactionBody. Use createTransactionBody instead.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/deprecate-createAndValidateTransactionBody branch from c18de50 to f858e3e Compare August 23, 2024 15:28
@Jimbo4350 Jimbo4350 force-pushed the jordan/deprecate-createAndValidateTransactionBody branch from f858e3e to 5e15672 Compare August 23, 2024 18:21
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Aug 23, 2024
Merged via the queue into main with commit 966462b Aug 23, 2024
24 of 25 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/deprecate-createAndValidateTransactionBody branch August 23, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants