-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated functions and update types and update writeTxFileTextEnvelopeCddl
to use new format
#746
Conversation
serialiseTxLedgerCddl
to use new formatwriteTxFileTextEnvelopeCddl
to use new format
writeTxFileTextEnvelopeCddl
to use new formatwriteTxFileTextEnvelopeCddl
to use new format
28adec6
to
2bdd8f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree with @Jimbo4350, we should try to preserve those tests.
2bdd8f0
to
fb5de89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the overall aim is to remove the module Cardano.Api.Internal.SerialiseLedgerCddl
in its entirety and have functions like legacyComparison
used in Cardano.Api.Internal.SerialiseTextEnvelope
to maintain backwards compatibility wrt deserialization. Can you create an issue for this? We should also require decode only tests upon the final removal.
Changelog
Context
serialiseTxLedgerCddl
anddeserialiseTxLedgerCddl
have been deprecated for two months, so I am removing them. Just realisedwriteTxFileTextEnvelopeCddl
is still using the old format, so I updated that and I will remove the compatibility layer in two months.How to trust this PR
Check that what I say in
Context
is true. Also that I haven't removed any still relevant tests.Check together with: IntersectMBO/cardano-cli#1052
Checklist