Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nightly ci and cancel conflicting runs #500

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Add nightly ci and cancel conflicting runs #500

merged 2 commits into from
Oct 25, 2024

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Sep 12, 2024 •
edited
Loading

This PR ensures we don't have duplicate CI runs for the same PR.
Also it adds nightly CI runs

@lehins lehins force-pushed the lehins/add-nightly-ci-cancel-conflicting-runs branch from ba5e782 to 73405a5 Compare September 20, 2024 20:47
@lehins lehins requested a review from a team as a code owner September 20, 2024 20:47
@lehins lehins force-pushed the lehins/add-nightly-ci-cancel-conflicting-runs branch from 73405a5 to 0ebeaf8 Compare October 25, 2024 18:07
neilmayhew
neilmayhew approved these changes Oct 25, 2024
View reviewed changes
Copy link

@neilmayhew neilmayhew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

There are probably other features we'll want to bring across from ledger, but we can leave that for another time.

@lehins lehins force-pushed the lehins/add-nightly-ci-cancel-conflicting-runs branch from 0ebeaf8 to 1f11a0c Compare October 25, 2024 21:40
@lehins lehins enabled auto-merge October 25, 2024 21:40
@lehins lehins merged commit 61790e2 into master Oct 25, 2024
24 checks passed
@lehins lehins deleted the lehins/add-nightly-ci-cancel-conflicting-runs branch October 25, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilmayhew neilmayhew neilmayhew approved these changes

@angerman angerman Awaiting requested review from angerman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lehins @neilmayhew