Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "create-testnet-data: augment/check node configuration file for genesis hashes and paths" #930

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 7, 2024

Changelog

- description: |
    Reverts https://github.com/IntersectMBO/cardano-cli/pull/908
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

In the end, we prefer checking node-configuration hashes only in the new command check-node-configuration (introduced by #923), so removing this feature from create-testnet-data.

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

@smelc smelc enabled auto-merge October 10, 2024 14:23
smelc added 2 commits October 14, 2024 09:57
…f any) for genesis hashes and paths"

This reverts commit 59ee97e64e7d7d8995c71a037ce68eff3360805b.
@smelc smelc added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 14, 2024
@carbolymer carbolymer added this pull request to the merge queue Oct 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2024
@smelc smelc added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 15, 2024
@smelc smelc added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 15, 2024
@smelc smelc added this pull request to the merge queue Oct 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 15, 2024
@smelc smelc added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit f04588a Oct 16, 2024
25 checks passed
@smelc smelc deleted the smelc/revert-908 branch October 16, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants