-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to the most recent Alonzo specification #2095
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bunch of the alonzo figures, all lining up so nicely with the spec, it's looking really great! I made a few comments about mostly trivial things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of minor things
@@ -33,6 +33,7 @@ library | |||
, microlens-th | |||
, mtl | |||
, nothunks | |||
, prettyprinter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this related to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the tests won't build without it. See Issue 2093, and the transcript of the build here
#2093
01b74f1
to
5fb1df1
Compare
Completed Figures 1, 2, 3, 4, 5, 6, 7, 8 and 12.
5fb1df1
to
78990a4
Compare
This latest push does a few things
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Completed Figures 1, 5, 6, 7, 8 and 12. Ormolise.
This PR implements all the functions in the most up todate specification in the above Figures.